Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support task flag #4

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Support task flag #4

merged 6 commits into from
Dec 18, 2024

Conversation

markdboyd
Copy link

@markdboyd markdboyd commented Dec 17, 2024

Changes proposed in this pull request:

Add support for pushing apps with the --task flag. From the CLI cf push docs:

--task
Push an app that is used only to execute tasks. The app will be staged, but not started and will have no route assigned.

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just adding support for new flag on cf push

@markdboyd markdboyd requested a review from a team December 17, 2024 22:28
@markdboyd markdboyd merged commit 0ca86b1 into main Dec 18, 2024
3 checks passed
@markdboyd markdboyd deleted the support-task-flag branch December 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants