Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using var for username #133

Merged
merged 1 commit into from
Sep 20, 2024
Merged

using var for username #133

merged 1 commit into from
Sep 20, 2024

Conversation

dandersonsw
Copy link
Contributor

Changes proposed in this pull request:

  • The docker_username param doesn't seem to be working like it should, so setting the username as a var

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just adding a variable

@dandersonsw dandersonsw requested a review from a team as a code owner September 20, 2024 18:24
@dandersonsw dandersonsw merged commit 9063efb into main Sep 20, 2024
1 check passed
@dandersonsw dandersonsw deleted the cf-hardened-images branch September 20, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants