Skip to content

fix hardcoding of app name in init-config script #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Nov 17, 2023

Related to #66

Changes proposed in this pull request:

  • fix hardcoding of app name when creating tunnel in init-config script

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Making sure the e2e tests are passing is a critical piece of ensuring that this authentication proxy for Opensearch works as expected and guaranteeing tenant isolation of data

@markdboyd markdboyd requested a review from a team November 17, 2023 21:52
@markdboyd markdboyd merged commit f8738de into main Nov 20, 2023
@markdboyd markdboyd deleted the fix-init-config branch November 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants