Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Task UI #4322

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Build Task UI #4322

merged 1 commit into from
Dec 14, 2023

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Dec 8, 2023 •
edited
Loading

Changes proposed in this pull request:

  • Updates the build history page with new styling, improved contextual information, and links to the new build tasks view
  • Adds a new page for viewing all build tasks for a single build
  • Other DB/API changes to support the above
  • Close Implement build checks UI #4171

security considerations

This solidifies the release of the initial UI associated with Build Tasks. It is gated to not appear in production until an SCR is completed documenting its architecture and any potential security risks.

@drewbo drewbo force-pushed the feat-build-task-ui branch 2 times, most recently from 040eff9 to be48c0c Compare December 8, 2023 23:55
@drewbo drewbo requested a review from a team December 8, 2023 23:55
@drewbo drewbo mentioned this pull request Dec 8, 2023
Closed
svenaas
svenaas reviewed Dec 12, 2023
View reviewed changes
scripts/create-dev-data.js Outdated Show resolved Hide resolved
@drewbo drewbo force-pushed the feat-build-task-ui branch from cf331e6 to 36fa5a8 Compare December 14, 2023 20:09
@drewbo drewbo requested review from svenaas, sknep and apburnes December 14, 2023 20:55
svenaas
svenaas reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@svenaas svenaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build task type descriptions are duplicated in a couple of places; is there a good way to avoid that?

Otherwise this looks good to me but I'm going to hold off on clicking Approve until @apburnes has a look since he was part of a few threads here that aren't yet resolved.

@svenaas
Copy link
Contributor

svenaas commented Dec 14, 2023

The build task type descriptions are duplicated in a couple of places; is there a good way to avoid that?

I went back and looked again. Duplication is between the migration and scripts/create-dev-data.js and there may not be an elegant way to avoid that.

apburnes
apburnes approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏗️ 🥳

svenaas
svenaas approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@svenaas svenaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right then. Here's another for good measure.

@drewbo drewbo merged commit 121bca9 into main Dec 14, 2023
3 checks passed
@drewbo drewbo deleted the feat-build-task-ui branch December 14, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenaas svenaas svenaas approved these changes

@apburnes apburnes apburnes approved these changes

@sknep sknep Awaiting requested review from sknep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement build checks UI
4 participants
@drewbo @svenaas @apburnes @sknep