fix: Improve brittle admin user API test #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drewbo This changes two things I spotted that could potentially allow failures due to timing conditions. I think these are both worthwhile, though I can't be certain this will resolve the matter. It had been a full week since the previous version was merged, with plenty of test runs since before you experienced that failure yesterday. |
drewbo
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes which I hope will sufficiently remediate #4333
Changes proposed in this pull request:
awaitcreateUAAIdentitycallssecurity considerations
None. This is an effort to prevent an unexpected and inconsistent test failure.