Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add e2e tests in staging, build env vars to build step #4335

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Dec 15, 2023

Changes proposed in this pull request:

  • add build env variables during the build step (ideally this would be abstracted)
  • add e2e tests to staging to catch this error

security considerations

Adds (then removes) credentialed users to the staging database

@drewbo drewbo force-pushed the fix-env-vars-build branch from 46a2ae5 to e578fb3 Compare December 15, 2023 18:31
@drewbo drewbo changed the title [WIP] fix: add e2e tests in staging, build env vars to build step fix: add e2e tests in staging, build env vars to build step Dec 18, 2023
@drewbo drewbo force-pushed the fix-env-vars-build branch from e578fb3 to fd843dc Compare December 18, 2023 17:15
@drewbo drewbo merged commit 916d096 into main Dec 18, 2023
3 checks passed
@drewbo drewbo deleted the fix-env-vars-build branch December 18, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants