fix: don't fail the last build log fetch #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
force-pushed
the
fix-last-build-log-s3
branch
from
532431b to
0a18f3f
Compare
svenaas
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
I'm not able to verify locally, but this is consistent with AWS source (some evidence conveniently grouped in this PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
InvalidRangeerror on AWS JS SDK V3Note
This is difficult to test because we don't archive build logs in development or staging. Also S3 is not currently running locally but I did manage to test this successfully on a branch which begins to implement that feature
security considerations
None