Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove isActive from User #4338 #4348

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

svenaas
Copy link
Contributor

@svenaas svenaas commented Dec 21, 2023

Fixes #4338

Changes proposed in this pull request:

  • Removes isActive from user column and model

security considerations

None. This removes an unused field from a model and corresponding database table.

@svenaas svenaas changed the title WIP chore: Remove isActive from User #4338 chore: Remove isActive from User #4338 Dec 21, 2023
@svenaas svenaas marked this pull request as ready for review December 21, 2023 18:04
@svenaas svenaas requested a review from a team December 21, 2023 18:04
@svenaas
Copy link
Contributor Author

svenaas commented Dec 21, 2023

@apburnes @drewbo I would appreciate your thoughts on api/services/Webhooks.js. The version in main made some use of User.isActive, which I removed, leaving behind logic dependent on a local isActive (const isActive = action === 'member_added') and want to be sure this is the correct path.

@svenaas svenaas force-pushed the 4338-remove-is-active-from-user branch from 126e6de to 30cc860 Compare December 22, 2023 11:07
@drewbo
Copy link
Contributor

drewbo commented Dec 29, 2023

Yeah, the local isActive refers to whether they are an active member of the federalist-local Github group. That functionality is deprecated so it should be fine

@svenaas svenaas merged commit 859775b into main Jan 2, 2024
3 checks passed
@svenaas svenaas deleted the 4338-remove-is-active-from-user branch January 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove isActive from User
2 participants