Skip to content

fix: use single build url upon creation (#4323) #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: use single build url upon creation (#4323) #4647

merged 1 commit into from
Nov 4, 2024

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Oct 30, 2024 •
edited
Loading

Changes proposed in this pull request:

Notes

  • Needs new tests
  • Verification on dev
  • Rewrite the url column on the build table using this logic

security considerations

None

@drewbo drewbo mentioned this pull request Oct 30, 2024
Closed
@apburnes
Copy link
Contributor

Running into a error in dev when trying to rebuild a site branch. Cannot destructure SiteBranchConfigs via utils/build.js

@drewbo drewbo force-pushed the fix-build-url branch 4 times, most recently from 94ed05b to 53c8ee5 Compare October 31, 2024 13:55
@drewbo
Copy link
Contributor Author

drewbo commented Oct 31, 2024 •
edited
Loading

Checking on dev, for all combination of preview, site, and domained urls:

  • Url appears correctly on frontend application
  • Url appears correctly on admin
  • Double check the url in the build response (via serializer)
  • Site receives the proper environment variables BASEURL and SITE_PREFIX
  • Github successful status checks show the url
  • Try an ASR for good measure

@drewbo drewbo force-pushed the fix-build-url branch 11 times, most recently from 95bafab to fea5f64 Compare November 4, 2024 14:00
@drewbo drewbo requested a review from a team November 4, 2024 16:29
apburnes
apburnes approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update and adds improved consistency with build url. Everything looks good and dev is working as expected.

@drewbo drewbo merged commit 646c090 into main Nov 4, 2024
12 checks passed
@drewbo drewbo deleted the fix-build-url branch November 4, 2024 17:11
@drewbo drewbo mentioned this pull request Nov 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apburnes apburnes apburnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Github status check on production branch of domained sites sends back non-domained URL
2 participants
@drewbo @apburnes