Fix site creation error #4705
Merged
Fix site creation error #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
force-pushed
the
fix-site-creation
branch
from
a2e804e to
dedb5f5
Compare
🤖 This is an automated code coverage reportTotal coverage (lines): 18.28% |
sknep
approved these changes
Jan 24, 2025
drewbo
force-pushed
the
fix-site-creation
branch
from
dedb5f5 to
36a8aa8
Compare
drewbo
force-pushed
the
fix-site-creation
branch
from
36a8aa8 to
104e223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Note
A more robust solution to this would be swapping the "sites" internal state to use react-query instead of redux. Happy to discuss that as a better/longer-term fix
security considerations
None