aarch64: fix get time runtime service failure #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @retrage -, any comments? |
|
Sorry for the late reply. Just a quick feedback. It’s good idea to allocate the reserved region, but the allocation should be done in populate_allocator function. For example, insert the change to here rust-hypervisor-firmware/src/efi/mod.rs Line 996 in 0c7a485 |
When enable efi_rtc inside guest kernel, a warning occurs: [ 0.764401] [Firmware Bug]: Unable to handle paging request in EFI runtime service [ 0.770671] ------------[ cut here ]------------ [ 0.772014] WARNING: CPU: 0 PID: 1 at drivers/firmware/efi/runtime-wrappers.c:262 virt_efi_get_time+0x12c/0x17c It derives from that there is lack of memory map descriptor for IO address of RTC_PL031 passed to kernel. Allocate IO Map for it before execute kernel/bootloader can avoid this failure and then we can get the right time inside guest. Fixes: cloud-hypervisor#289 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
jongwu
force-pushed
the
fix_gettime_arm
branch
from
0c7a485 to
bb6b752
Compare
|
Thanks @retrage -, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enable efi_rtc inside guest kernel, a warning occurs:
[ 0.764401] [Firmware Bug]: Unable to handle paging request in EFI runtime service
[ 0.770671] ------------[ cut here ]------------
[ 0.772014] WARNING: CPU: 0 PID: 1 at drivers/firmware/efi/runtime-wrappers.c:262 virt_efi_get_time+0x12c/0x17c
It derives from that there is lack of memory map descriptor for IO address of RTC_PL031 passed to kernel. Allocate IO Map for it before execute kernel/bootloader can avoid this failure and then we can get the right time inside guest.
Fixes: #289