fdt: enumerate all memory nodes present#346
Merged
retrage merged 1 commit intocloud-hypervisor:mainfrom Aug 24, 2024
Merged
Conversation
thomasbarrett
force-pushed
the
multiple-fdt-memory-nodes
branch
from
fc55458 to
83531ed
Compare
Author
|
This fixes cloud-hypervisor/cloud-hypervisor#6632 |
retrage
reviewed
Aug 20, 2024
Contributor
retrage
left a comment
retrage
left a comment
There was a problem hiding this comment.
Thank you so much for fixing it. It looks good to me. I have a few minor change requests.
It is possible for the device tree to have multiple memory nodes. Iterate through all regions defined by all memory nodes. Signed-off-by: Thomas Barrett <tbarrett@crusoe.ai>
thomasbarrett
force-pushed
the
multiple-fdt-memory-nodes
branch
from
83531ed to
08e879f
Compare
retrage
approved these changes
Aug 20, 2024
Contributor
|
It looks like the arm64 CI runner is not started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for the device tree to have multiple memory nodes. Iterate through all regions defined by all memory nodes.