Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: removed unsupported inline comments #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DohouM
Copy link

@DohouM DohouM commented Dec 7, 2022

Due to a non-implementation in oslo.config, inline comments in the config files are not currently supported.

I discovered this during my testing of cloudbase-init images in Openstack, here are the logs :

2022-11-25 15:25:18.360 1820 ERROR cloudbaseinit.init [-] plugin 'SetUserPasswordPlugin' failed with error 'Value for option inject_user_password from LocationInfo(location=<Locations.user: (4, True)>, detail='C:\\Program Files\\Cloudbase Solutions\\Cloudbase-Init\\conf\\cloudbase-init.conf') is not valid: Unexpected boolean value 'True  # Use password from the metadata (not random).'': oslo_config.cfg.ConfigFileValueError: Value for option inject_user_password from LocationInfo(location=<Locations.user: (4, True)>, detail='C:\\Program Files\\Cloudbase Solutions\\Cloudbase-Init\\conf\\cloudbase-init.conf') is not valid: Unexpected boolean value 'True  # Use password from the metadata (not random).'
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init [-] Value for option inject_user_password from LocationInfo(location=<Locations.user: (4, True)>, detail='C:\\Program Files\\Cloudbase Solutions\\Cloudbase-Init\\conf\\cloudbase-init.conf') is not valid: Unexpected boolean value 'True  # Use password from the metadata (not random).': oslo_config.cfg.ConfigFileValueError: Value for option inject_user_password from LocationInfo(location=<Locations.user: (4, True)>, detail='C:\\Program Files\\Cloudbase Solutions\\Cloudbase-Init\\conf\\cloudbase-init.conf') is not valid: Unexpected boolean value 'True  # Use password from the metadata (not random).'
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init Traceback (most recent call last):
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init   File "C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\oslo_config\cfg.py", line 2694, in _do_get
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init     return (convert(val), alt_loc)
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init   File "C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\oslo_config\cfg.py", line 2664, in convert
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init     self._substitute(value, group, namespace), opt)
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init   File "C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\oslo_config\cfg.py", line 2791, in _convert_value
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init     return opt.type(value)
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init   File "C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\oslo_config\types.py", line 250, in __call__
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init     raise ValueError('Unexpected boolean value %r' % value)
2022-11-25 15:25:18.439 1820 ERROR cloudbaseinit.init ValueError: Unexpected boolean value 'True  # Use password from the metadata (not random).'

Due to a non-implementation in `oslo.config`, inline comments in the config files are not currently supported.
@ader1990
Copy link
Member

ader1990 commented Dec 9, 2022

Hello,

We are currently using opendev for patches:
https://review.opendev.org/q/project:x/cloudbase-init

How to create an account and contribute to:
https://docs.openstack.org/contributors/common/setup-gerrit.html

Thank you,
Adrian Vladu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants