Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network metadata support for vmware metadata service #130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Eifoen
Copy link

@Eifoen Eifoen commented Jan 2, 2024

  • Added parsing of vmware metadata as NetworkDetailsV2
  • Using NoCloudNetworkConfigV1Parser for parsing the data

Functionality is analog to cloud-init as per https://cloudinit.readthedocs.io/en/latest/reference/datasources/vmware.html#instance-data-and-lazy-networks and https://github.com/canonical/cloud-init/blob/4f60ff099eb0a6f57595706f4d34cf713d3c02b1/cloudinit/sources/DataSourceVMware.py#L275

- Added parsing of vmware metadata as NetworkDetailsV2
- Using NoCloudNetworkConfigV1Parser for parsing the data
- Functionality is analog to cloud-init
@ader1990
Copy link
Member

Hello,

We are currently using opendev for patches:
https://review.opendev.org/q/project:x/cloudbase-init

How to create an account and contribute to:
https://docs.openstack.org/contributors/common/setup-gerrit.html

Thank you,
Adrian Vladu.

@FlorianLaunay
Copy link
Contributor

Hi @Eifoen . This feature is already followed in #107

@FlorianLaunay
Copy link
Contributor

Hi @ader1990
Could you please close this PR ? This feature was finally brought by f0fe66b in release 1.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants