Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop netifaces dependency #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 3, 2024

  1. Drop netifaces dependency

    The netifaces library is no longer maintained, which is why we
    need to drop this dependency.
    
    There is only one place in which netifaces is being used, a
    trivial function that retrives the mac address for a given ip
    address.
    
    Thankfully, we already have a cloudbase-init "get_adapter_addresses"
    function that uses ctypes to call GetAdaptersAddresses, which
    happens to be the same Windows function used by netifaces.
    
    Worth mentioning that netifaces is the only compilable cloudbase-init
    dependency that does not provide a wheel package.
    
    Fixes: cloudbase#140
    petrutlucian94 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    dd45caf View commit details
    Browse the repository at this point in the history