Raise clear error message on invalid Windows minion WinRM creds.

Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
cloudbase · Mar 4, 2024 · 9a51bb4 · 9a51bb4
1 parent f32c251
commit 9a51bb4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/coriolis/osmorphing/osmount/windows.py b/coriolis/osmorphing/osmount/windows.py
@@ -5,6 +5,7 @@
 import uuid
 
 from oslo_log import log as logging
+from winrm import exceptions as winrm_exceptions
 
 from coriolis import exception
 from coriolis.osmorphing.osmount import base
@@ -36,7 +37,22 @@ def check_os(self):
                 "(get-ciminstance Win32_OperatingSystem).Caption")
             LOG.debug("Windows version: %s", version_info)
             return True
+        except winrm_exceptions.InvalidCredentialsError as ex:
+            raise exception.NotAuthorized(
+                message="The WinRM connection credentials are invalid. "
+                        "If you are using a template with a default "
+                        "pre-baked username/password, please ensure "
+                        "that you have passed the credentials to the "
+                        "destination Coriolis plugin you have selected,"
+                        " either via the Target Environment parameters "
+                        "set when creating the Migration/Replica, or "
+                        "by setting it in the destination plugin's "
+                        "dedicated section of the coriolis.conf "
+                        "static configuration file.") from ex
         except exception.CoriolisException:
+            LOG.debug(
+                "Failed Windows OSMount OS check: %s",
+                utils.get_exception_details())
             pass
 
     def _run_diskpart_script(self, script):

diff --git a/coriolis/wsman.py b/coriolis/wsman.py
@@ -100,8 +100,9 @@ def set_timeout(self, timeout):
     def _exec_command(self, cmd, args=[], timeout=None):
         timeout = int(timeout or self._conn_timeout)
         self.set_timeout(timeout)
-        shell_id = self._protocol.open_shell(codepage=CODEPAGE_UTF8)
+        shell_id = None
         try:
+            shell_id = self._protocol.open_shell(codepage=CODEPAGE_UTF8)
             command_id = self._protocol.run_command(shell_id, cmd, args)
             try:
                 (std_out,
@@ -116,7 +117,8 @@ def _exec_command(self, cmd, args=[], timeout=None):
 
             return (std_out, std_err, exit_code)
         finally:
-            self._protocol.close_shell(shell_id)
+            if shell_id:
+                self._protocol.close_shell(shell_id)
 
     def exec_command(self, cmd, args=[], timeout=None):
         LOG.debug("Executing WSMAN command: %s", str([cmd] + args))