Add unit tests for coriolis.tasks.* modules
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
force-pushed
the
tasks-tests
branch
4 times, most recently
from
fe8f8a5
to
887103a
Compare
Dany9966
force-pushed
the
tasks-tests
branch
5 times, most recently
from
4e7f653
to
bc44c24
Compare
Dany9966
force-pushed
the
tasks-tests
branch
2 times, most recently
from
8fca794
to
a548a23
Compare
This commit refactors the way a `TaskRunner` retrieves shared lib dirs for providers
This patch refactors the `minion_pool_tasks` module in order to make it more testable.
This patch fixes a bug where not all required task info properties would be returned by `get_required_task_info_properties`, caused by the assumption that the set `.union()` method would unionize in place, which in fact it does not.
Refactors replica deployment task connection info validation in order to make it more testable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.