-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for coriolis/taskflow
modules
#288
Merged
Dany9966
merged 4 commits into
cloudbase:master
from
mihaelabalutoiu:add-taskflow-unit-tests
Feb 21, 2024
Merged
Add unit tests for coriolis/taskflow
modules
#288
Dany9966
merged 4 commits into
cloudbase:master
from
mihaelabalutoiu:add-taskflow-unit-tests
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaelabalutoiu
force-pushed
the
add-taskflow-unit-tests
branch
from
January 22, 2024 13:02
ddc1f1f
to
1df3758
Compare
Dany9966
requested changes
Feb 20, 2024
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
for the current module. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-taskflow-unit-tests
branch
from
February 21, 2024 11:57
1df3758
to
50b8848
Compare
Done. I made the changes. Please take a look now, thanks. |
Dany9966
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the following modules:
taskflow/runner.py
taskflow/utils.py
taskflow/base.py