Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for coriolis.cmd.* modules #289

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

Cristi1324
Copy link
Contributor

This PR add unit tests for 'coriolis.cmd.*' modules

@Cristi1324 Cristi1324 changed the title Add unit tests for 'coriolis.cmd.*' modules Add unit tests for '''coriolis.cmd.*''' modules Jan 22, 2024
@Cristi1324 Cristi1324 changed the title Add unit tests for '''coriolis.cmd.*''' modules Add unit tests for 'coriolis.cmd.*' modules Jan 22, 2024
@Cristi1324 Cristi1324 changed the title Add unit tests for 'coriolis.cmd.*' modules Add unit tests for coriolis.cmd.* modules Jan 22, 2024
Copy link
Contributor

@Dany9966 Dany9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the import comments. will merge after you fix those


from unittest import mock

import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: No need to separate sys here. It can go in the same group as the unittest import


from unittest import mock

import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before


from unittest import mock

import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before


from unittest import mock

import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before


from unittest import mock

import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before


from unittest import mock

import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same


from unittest import mock

import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@Dany9966 Dany9966 merged commit 13d71c3 into cloudbase:master Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants