Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osmorphing.osdetect* unit tests #306

Merged

Conversation

mihaelabalutoiu
Copy link
Contributor

@mihaelabalutoiu mihaelabalutoiu commented Mar 29, 2024

This PR adds unit testing for the following module:

  • osmorphing.osdetect.amazon.py
  • osmorphing.osdetect.base.py
  • osmorphing.osdetect.centos.py
  • osmorphing.osdetect.coreos.py
  • osmorphing.osdetect.debian.py
  • osmorphing.osdetect.manager.py
  • osmorphing.osdetect.openwrt.py
  • osmorphing.osdetect.oracle.py
  • osmorphing.osdetect.redhat.py
  • osmorphing.osdetect.rocky.py
  • osmorphing.osdetect.suse.py
  • osmorphing.osdetect.ubuntu.py
  • osmorphing.osdetect.windows.py

@mihaelabalutoiu mihaelabalutoiu force-pushed the add-osmorphing-osdetect-unit-tests branch from 7237d4f to c5c3214 Compare April 1, 2024 11:54
@mihaelabalutoiu mihaelabalutoiu changed the title Add osmorphing.osdetect unit tests Add osmorphing.osdetect* unit tests Apr 1, 2024
Copy link
Contributor

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some small comments, everything LGTM!

coriolis/tests/osmorphing/osdetect/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/osmorphing/osdetect/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/osmorphing/osdetect/test_base.py Outdated Show resolved Hide resolved
coriolis/tests/osmorphing/osdetect/test_windows.py Outdated Show resolved Hide resolved
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-osmorphing-osdetect-unit-tests branch from c5c3214 to be71c80 Compare April 19, 2024 11:30
@mihaelabalutoiu
Copy link
Contributor Author

I made the changes, please take a look now. Thank you!

Copy link
Contributor

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two more comments before this PR looks good to me!

coriolis/tests/osmorphing/osdetect/test_windows.py Outdated Show resolved Hide resolved
module
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu mihaelabalutoiu force-pushed the add-osmorphing-osdetect-unit-tests branch from be71c80 to d01d2ad Compare April 22, 2024 15:49
@mihaelabalutoiu
Copy link
Contributor Author

I updated the code, please take a look now. Thanks!

Copy link
Contributor

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dany9966 Dany9966 merged commit b0c8dbf into cloudbase:master Apr 22, 2024
4 checks passed
@mihaelabalutoiu mihaelabalutoiu deleted the add-osmorphing-osdetect-unit-tests branch April 22, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants