-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add osmorphing.osdetect*
unit tests
#306
Add osmorphing.osdetect*
unit tests
#306
Conversation
7237d4f
to
c5c3214
Compare
osmorphing.osdetect
unit testsosmorphing.osdetect*
unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some small comments, everything LGTM!
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
c5c3214
to
be71c80
Compare
I made the changes, please take a look now. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two more comments before this PR looks good to me!
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
be71c80
to
d01d2ad
Compare
I updated the code, please take a look now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds unit testing for the following module:
osmorphing.osdetect.amazon.py
osmorphing.osdetect.base.py
osmorphing.osdetect.centos.py
osmorphing.osdetect.coreos.py
osmorphing.osdetect.debian.py
osmorphing.osdetect.manager.py
osmorphing.osdetect.openwrt.py
osmorphing.osdetect.oracle.py
osmorphing.osdetect.redhat.py
osmorphing.osdetect.rocky.py
osmorphing.osdetect.suse.py
osmorphing.osdetect.ubuntu.py
osmorphing.osdetect.windows.py