OSMount: fix internal VG name referencing conflict. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
reviewed
Jul 3, 2024
aznashwan
force-pushed
the
fix-multi-pv-vg-naming
branch
4 times, most recently
from
bbbf250
to
3e98ade
Compare
The Coriolis OSMount code would internally keep a mapping between names of VGs it should activate and their PVs, which could potentially lead to VGs with multiple PVs to be referneced both by their original name, as well as a new one Coriolis generates to avoid naming conflicts in /dev/$VG_NAME/$LVM_NAME. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
aznashwan
force-pushed
the
fix-multi-pv-vg-naming
branch
from
3e98ade
to
8eae765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Coriolis OSMount code would internally keep a mapping between names of VGs it should activate and their PVs, which could potentially lead to VGs with multiple PVs to be referneced both by their original name, as well as a new one Coriolis generates to avoid naming conflicts in /dev/$VG_NAME/$LVM_NAME.