Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Adds mock patch autospec fixture #323

Merged
merged 1 commit into from
Jul 3, 2024

Commits on Jun 27, 2024

  1. tests: Adds mock patch autospec fixture

    When mocking something, there's the possibility to reference a
    property that does not exist, or call a method with invalid arguments,
    but the unit tests to keep passing, resulting in false positives.
    
    We've seen this issue several times in OpenStack, and we have created
    and started using a mock patch fixture (can be seen in OpenStack Nova's test.py)
    which enables autospec by default.
    
    This guarantees 2 things: that the thing we're patching exists, and if it's
    callable, that the calls respect the callable's signature (e.g.: no unknown
    arguments can be used).
    claudiubelu committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2fcf641 View commit details
    Browse the repository at this point in the history