Add unit tests for coriolisclient.cli.* modules
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
requested changes
Apr 23, 2024
Comment on lines
4
to
7
| from cliff import command | ||
| from cliff import lister | ||
| from cliff import show | ||
| from unittest import mock |
There was a problem hiding this comment.
cliff is a third-party package, while unittest is standard. Please separate their imports, and apply everywhere:
Suggested change
| from cliff import command | |
| from cliff import lister | |
| from cliff import show | |
| from unittest import mock | |
| from unittest import mock | |
| from cliff import command | |
| from cliff import lister | |
| from cliff import show |
There was a problem hiding this comment.
Please apply this to all the files. Other than that, this LGTM
Comment on lines
135
to
136
| mock_get_parser.return_value.add_argument.assert_called_once_with( | ||
| 'appliance_id', help="The appliance ID") |
| mock_lic_status = mock.Mock() | ||
| self.mock_app.client_manager.coriolis.licensing.status = \ | ||
| mock_lic_status | ||
| self.licensce.app = self.mock_app |
Comment on lines
183
to
184
| mock_get_parser.return_value.add_argument.assert_called_once_with( | ||
| 'appliance_id', help="The appliance ID") |
| mock.sentinel.licence_pem_file | ||
| mock_licence = mock.Mock() | ||
| self.mock_app.client_manager.coriolis.licensing.register = mock_licence | ||
| self.licensce.app = self.mock_app |
Comment on lines
125
to
128
| mock_get_parser.return_value.add_argument.assert_has_calls([ | ||
| mock.call('appliance_id', help='The appliance ID'), | ||
| mock.call('reservation_id', help='The reservation ID') | ||
| ]) |
| mock_licensing_reservations = mock.Mock() | ||
| self.mock_app.client_manager.coriolis.licensing_reservations = \ | ||
| mock_licensing_reservations | ||
| self.reservation.app = self.mock_app |
Comment on lines
177
to
180
| mock_get_parser.return_value.add_argument.assert_has_calls([ | ||
| mock.call('appliance_id', help='The appliance ID'), | ||
| mock.call('reservation_id', help='The reservation ID') | ||
| ]) |
| mock_licensing_reservations = mock.Mock() | ||
| self.mock_app.client_manager.coriolis.licensing_reservations = \ | ||
| mock_licensing_reservations | ||
| self.reservation.app = self.mock_app |
| mock_licensing_server = mock.Mock() | ||
| self.mock_app.client_manager.coriolis.licensing_server = \ | ||
| mock_licensing_server | ||
| self.server.app = self.mock_app |
Cristi1324
force-pushed
the
add_cli_unit_tests
branch
2 times, most recently
from
9c9883b
to
d51305f
Compare
Cristi1324
force-pushed
the
add_cli_unit_tests
branch
from
5c3461a
to
91b395b
Compare
Dany9966
reviewed
May 13, 2024
|
|
||
| def setUp(self): | ||
| super(LicensingStatusFormatterTestCase, self).setUp() | ||
| self.licensce = licensing.LicensingStatusFormatter() |
There was a problem hiding this comment.
Please change licensce to either licence or license :D Here, and everywhere else
Cristi1324
force-pushed
the
add_cli_unit_tests
branch
from
91b395b
to
1ccb8c2
Compare
Dany9966
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
coriolisclient.cli.*modules.