Add more unit tests for coriolisclient.cli.* modules
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cristi1324
changed the title
coriolisclient.cli.* modules
Cristi1324
force-pushed
the
add_cli_unit_tests_2
branch
3 times, most recently
from
382084a
to
706eff0
Compare
Dany9966
requested changes
May 22, 2024
| "types": [1, 2, -1] | ||
| } | ||
|
|
||
| result = self.provider._get_formatted_data(obj) |
There was a problem hiding this comment.
Could you also please add an assertLogs?
| self.assertEqual( | ||
| ( | ||
| mock.sentinel.type, | ||
| '"mock_schema"' |
There was a problem hiding this comment.
I don't think I like this result for json.dumps. Could you please add a more complex example? Including objects and lists?
| exceptions.CoriolisException, | ||
| replica_schedules._parse_expiration_date, | ||
| value | ||
| ) |
There was a problem hiding this comment.
Please add a test case for _add_schedule_group where you at least check that arg group 'Scheduleis added to the passedparser`.
| ( | ||
| mock.sentinel.id, | ||
| ('mock_instance3%(ls)smock_instance1%(ls)smock_instance2' | ||
| % {"ls": os.linesep}), |
There was a problem hiding this comment.
This could fail if run on Windows. Please use '\n' instead
Suggested change
| % {"ls": os.linesep}), | |
| % {"ls": "\n"}), |
Cristi1324
force-pushed
the
add_cli_unit_tests_2
branch
from
706eff0
to
0652c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
coriolisclient.cli.migrations...servicesmodules.