Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: layer-name variable, lambda-function iamrole policyName and module example #35

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: layer-name variable, lambda-function iamrole policyName and module example #35

merged 1 commit into from
Mar 11, 2024

Conversation

h1manshu98
Copy link
Member

what

  • variable name to pass name of Lambda-Layer from names to layer_names
  • Update default timeout for Lambda-Function from 3 to 10
  • Update IAMPolicy names and permissions that are attached to IAMRole of Lambda-Function.
  • Update module _example to make it work in 1 go.

@h1manshu98 h1manshu98 requested a review from a team January 17, 2024 18:28
@clouddrove-ci clouddrove-ci self-assigned this Jan 17, 2024
@h1manshu98 h1manshu98 self-assigned this Jan 17, 2024
@h1manshu98 h1manshu98 added the enhancement New feature or request label Jan 17, 2024
13archit
13archit reviewed Jan 17, 2024
View reviewed changes
variables.tf Show resolved Hide resolved
13archit
13archit reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix tflint and checks failing.

vaibhav7797
vaibhav7797 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

theprashantyadav
theprashantyadav approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@theprashantyadav theprashantyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit 33f8901 into master Mar 11, 2024
21 of 22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/variables-and-example branch March 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13archit 13archit 13archit left review comments

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@theprashantyadav theprashantyadav theprashantyadav approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@h1manshu98 h1manshu98

@clouddrove-ci clouddrove-ci

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@h1manshu98 @themaniskshah @theprashantyadav @13archit @vaibhav7797 @clouddrove-ci