Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enhancements #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnkithaBH
Copy link

Hello Team,

We tested the module, and have identified a few changes and additions that we would like to implement. We believe that these enhancements will not only improve the module but also ensure it is versatile and compatible with different use cases that end users may encounter. These updates will allow for more effective internal usage.

Changes and Additions Contributed

  • Added the below variables,
  1. custom_tags - To be able to use custom tags
  2. identity_type and user_assigned_identity_ids - Currently, the resource block of the server does not have the scope to use identity argument. Hence, added the same and these variables are leveraged to provide flexibility in usage.
  3. entra_authentication - The module does not include "entra authentication", which is considered to be commonly used with mysql flexible server. Hence, added the same and the variable is leveraged to provide flexibility in usage.
  4. server_parameters_enabled - To add flexibility and control, in leveraging "server parameters" configuration.
  5. create_password - Currently the module uses count= var.admin_password == null ? 1 : 0 to check whether the password should be created or not. However, this particular configuration is throwing an error saying, The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To overcome the same, this variable is used.
  • Replaced the default value of high_availabilty variable to null; to enhance flexibility and provide the end user the control to choose HA or not to chose HA.

  • Added conditional expression for tags.

  • Added resource block to create mysql server active directory administrator for entra authentication.

  • Added identity block to the scope and conditional expression for name of the mysql server to be able to use custom names and follow internal naming standards by the end user.

The code structure is preserved while enhancing flexibility.

We hope these changes are considered.

Looking forward to use the module with the new version including the changes.

Kind Regards,
Ankitha

@AnkithaBH AnkithaBH mentioned this pull request Oct 18, 2024
@AnkithaBH
Copy link
Author

Hello Team,

Any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant