DBT-770: Removing logging from tracking adapter when disabled #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niteshy
reviewed
Apr 9, 2024
| @@ -200,13 +200,8 @@ def track_usage(tracking_payload): | |||
|
|
|||
| global usage_tracking | |||
|
|
|||
| logger.debug( | |||
| f"Usage tracking flag {usage_tracking}. To turn on/off use usage_tracking flag in profiles.yml" | |||
There was a problem hiding this comment.
Agree, we should avoid printing this line every time. May be only once during the whole run other remove it completely.
| @@ -82,6 +82,7 @@ def dwx_target(): | |||
| "user": os.getenv("DBT_HIVE_USER"), | |||
| "password": os.getenv("DBT_HIVE_PASSWORD"), | |||
| "http_path": os.getenv("DBT_HIVE_HTTP_PATH") or "cliservice", | |||
| "usage_tracking": False, | |||
There was a problem hiding this comment.
Let's make it configurable such that we can configure the following options rather than boolean value
- Send the events
- Log the events
- Completely skip (no log) the events.
if we can parse these logs, then these event logs can be useful to construct the timeline and queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently, there are many logs regarding tracking adapter even when disabled. For example:
This patch will reduce the noise of these logs when its disabled
Internal Jira ticket number or external issue link
https://jira.cloudera.com/browse/DBT-770
Testing procedure/screenshots(if appropriate):
Before the change: https://gist.github.com/vamshikolanu/524bf70a4bd5199cc0d3f909790f2ac2
After the change: https://gist.github.com/vamshikolanu/03a8fe2add50b8c22c4a169c38b8b506
Checklist before requesting a review