dont use isinstance

cloudera · Sep 17, 2024 · 480c80f · 480c80f
1 parent 473eae8
commit 480c80f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/desktop/core/src/desktop/lib/conf.py b/desktop/core/src/desktop/lib/conf.py
@@ -225,7 +225,7 @@ def __init__(self, key=_ANONYMOUS, default=None, dynamic_default=None, required=
     if (isinstance(default, numbers.Number) or pytype(default) is bool) and not isinstance(type(default), pytype(default)):
       raise ValueError("%s: '%s' does not match that of the default value %r (%s)" % (key, type, default, pytype(default)))
 
-    if isinstance(type, bool):
+    if type is bool:
       LOG.warning("%s is of type bool. Resetting it as type 'coerce_bool'." " Please fix it permanently" % (key,))
       type = coerce_bool
 
@@ -646,7 +646,7 @@ def coerce_bool(value):
 
 
 def coerce_string(value):
-  if isinstance(value, list):
+  if type(value) is list:
     return ','.join(value)
   else:
     return value