Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Importer] Handle malformed data to improve delimiter guessing #3423

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Aug 2, 2023

What changes were proposed in this pull request?

  • Replacing '\r\n' with '\n'

How was this patch tested?

  • Manual
  • Unit test

Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe change variable names instead of adding 1?

@agl29 agl29 merged commit 895cfd4 into master Aug 2, 2023
2 checks passed
@agl29 agl29 deleted the importer_guess_delimiter branch August 2, 2023 16:29
tabraiz12 pushed a commit that referenced this pull request Oct 4, 2023
wing2fly pushed a commit that referenced this pull request Mar 6, 2024
…ssing (#3423)

(cherry picked from commit 895cfd4)
(cherry picked from commit de3858f)
Change-Id: I6c8d2bdd2391007ea9ffb5faf63dbb335ea52f4a
(cherry picked from commit 8a78d25)
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
…ssing (#3423)

(cherry picked from commit 895cfd4)
(cherry picked from commit de3858f)
Change-Id: I6c8d2bdd2391007ea9ffb5faf63dbb335ea52f4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants