Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fb] Fix render method call for new storage browser flag #3426

Closed
wants to merge 1 commit into from
Closed

[fb] Fix render method call for new storage browser flag #3426

wants to merge 1 commit into from

Conversation

Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Aug 4, 2023 •
edited
Loading

What changes were proposed in this pull request?

  • Checking for new storage browser flag at the top of the function was triggering the render method without any data.
  • This was causing the API to return empty data for both direct public API call and was visible in Hue UI also.
  • Now correct placement of the check fixes this issue.

How was this patch tested?

  • Manually in local Hue (since this is WIP feature flag for now).

@Harshg999 Harshg999 enabled auto-merge (squash) August 4, 2023 08:44
@Harshg999 Harshg999 closed this Aug 4, 2023
auto-merge was automatically disabled August 4, 2023 09:30

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agl29 agl29 agl29 approved these changes

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

@bjornalm bjornalm Awaiting requested review from bjornalm

@nidhibhatg nidhibhatg Awaiting requested review from nidhibhatg

Assignees

@Harshg999 Harshg999

@nidhibhatg nidhibhatg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harshg999 @agl29 @nidhibhatg