[compute] check correctly for is_compute for session_type #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the problem is that when multiple queries are executed, we are not able to reuse the existing sessions as the session reuse is broken. if computes are in use then use compute[name] as the type otherwise fallback to old snippet[type] and use it everywhere. Change-Id: I0e6cb1149ca7961fc799ccce69fe70343d241bb5
amitsrivastava
requested review from
wing2fly,
ranade1,
athithyaaselvam,
agl29,
Harshg999 and
tabraiz12
Harshg999
reviewed
Oct 24, 2023
| @@ -316,11 +317,11 @@ def execute(self, notebook, snippet): | |||
| db = self._get_db(snippet, interpreter=self.interpreter) | |||
|
|
|||
| statement = self._get_current_statement(notebook, snippet) | |||
| session = self._get_session(notebook, snippet['type']) | |||
| compute = snippet.get('compute') | |||
There was a problem hiding this comment.
Snippet will always have compute? And compute will have name?
There was a problem hiding this comment.
It can potentially be undefined in the UI:
Not sure in which scenario but perhaps when loading back old saved editor documents, from before computes were introduced. I'm guessing is_compute takes care of checking it @amitsrivastava?
There was a problem hiding this comment.
Now made the checks safer.
… previous call. Change-Id: Ice8f9a48344a8b6008d0c0e632ddc20948034da5
athithyaaselvam
pushed a commit
that referenced
this pull request
Feb 5, 2024
the problem is that when multiple queries are executed, we are not able to reuse the existing sessions as the session reuse is broken. if computes are in use then use compute[name] as the type otherwise fallback to old snippet[type] and use it everywhere. frontend update to send the session_type from the session returned by previous call. Change-Id: I0e6cb1149ca7961fc799ccce69fe70343d241bb5 (cherry picked from commit 0e8667e)
wing2fly
pushed a commit
that referenced
this pull request
Mar 6, 2024
…3510) the problem is that when multiple queries are executed, we are not able to reuse the existing sessions as the session reuse is broken. if computes are in use then use compute[name] as the type otherwise fallback to old snippet[type] and use it everywhere. frontend update to send the session_type from the session returned by previous call. Change-Id: I0e6cb1149ca7961fc799ccce69fe70343d241bb5 (cherry picked from commit 0e8667e) (cherry picked from commit c454852) (cherry picked from commit b5d5802)
athithyaaselvam
pushed a commit
that referenced
this pull request
Mar 14, 2024
…3510) the problem is that when multiple queries are executed, we are not able to reuse the existing sessions as the session reuse is broken. if computes are in use then use compute[name] as the type otherwise fallback to old snippet[type] and use it everywhere. frontend update to send the session_type from the session returned by previous call. Change-Id: I0e6cb1149ca7961fc799ccce69fe70343d241bb5 (cherry picked from commit 0e8667e) (cherry picked from commit c454852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the problem is that when multiple queries are executed, we are not able to reuse the existing sessions as the session reuse is broken.
if computes are in use then use compute[name] as the type otherwise fallback to old snippet[type] and use it everywhere.
Change-Id: I0e6cb1149ca7961fc799ccce69fe70343d241bb5