[fb] Add File Browser branding for Google Storage #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanAhlen
requested review from
tabraiz12,
bjornalm,
agl29,
Harshg999 and
nidhibhatg
bjornalm
approved these changes
Nov 1, 2023
| @@ -43,7 +43,7 @@ else: | |||
| %elif path.lower().find('gs://') == 0: | |||
| <li style="padding-top: 12px"> | |||
| <span class="breadcrumb-link homeLink"> | |||
| <svg class="hi"><use xlink:href='#hi-adls'></use></svg> | |||
| <svg class="hi"><use xlink:href='#hi-gs'></use></svg> | |||
There was a problem hiding this comment.
xlink:href is deprected, but I guess the usage is all over the place in hue. See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href
There was a problem hiding this comment.
Nice catch. Will fix separately.
Harshg999
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested