Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gs] Change icon in importer path modal #3522

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[gs] Change icon in importer path modal #3522

merged 1 commit into from
Nov 1, 2023

Conversation

Harshg999
Copy link
Collaborator

What changes were proposed in this pull request?

  • Change icon from ABFS placeholder to GS

How was this patch tested?

  • Manually tested

@Harshg999 Harshg999 self-assigned this Nov 1, 2023
JohanAhlen
JohanAhlen approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agl29
agl29 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@agl29 agl29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agl29 agl29 enabled auto-merge (squash) November 1, 2023 12:05
@agl29 agl29 merged commit 1bd53ae into master Nov 1, 2023
4 of 5 checks passed
@agl29 agl29 deleted the importer-gs-icon branch November 1, 2023 12:25
athithyaaselvam pushed a commit that referenced this pull request Feb 5, 2024
@Harshg999
[gs] Change icon in importer path modal (#3522)
6dc121d 
(cherry picked from commit 1bd53ae)
wing2fly pushed a commit that referenced this pull request Mar 6, 2024
@Harshg999 @wing2fly
CDPD-48829: [gs] Change icon in importer path modal (#3522)
4065178 
(cherry picked from commit 1bd53ae)
(cherry picked from commit 6dc121d)
Change-Id: I7c0b3d93d07bae73ec76cdaa6e141cd5b4f2bf1a
(cherry picked from commit d82c1ca)
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
@Harshg999 @wing2fly
CDPD-48829: [gs] Change icon in importer path modal (#3522)
d82c1ca 
(cherry picked from commit 1bd53ae)
(cherry picked from commit 6dc121d)
Change-Id: I7c0b3d93d07bae73ec76cdaa6e141cd5b4f2bf1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@agl29 agl29 agl29 approved these changes

@bjornalm bjornalm Awaiting requested review from bjornalm

Assignees

@Harshg999 Harshg999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harshg999 @JohanAhlen @agl29