[editor] Move the SQL Syntax Dropdown from mako to js to get rid of inline script #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanAhlen
requested review from
tabraiz12,
bjornalm,
Harshg999,
nidhibhatg and
ananya-agarwal
bjornalm
approved these changes
Mar 13, 2024
Harshg999
approved these changes
Mar 19, 2024
athithyaaselvam
pushed a commit
that referenced
this pull request
Jun 10, 2024
…get rid of inline script (#3653) No code changes other than linting and some small clean-up. (cherry picked from commit b6b2ecc) (cherry picked from commit 273e39e0c106e74828691887209dce1c1d6b983b) Change-Id: Ie0c07a005df31ab5ee015deb3e7a734c753435c7 (cherry picked from commit 6372faf1d50990464f42cf0c47fc78edb3064ea6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes other than linting and some small clean-up.
Tested manually and added some simple unit tests.