-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][cleanup] Refactor and remove old Py2 code checks and methods #3683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this up. It was very much needed.
I could only go through 10% of the changes. I am assuming that you have verified the build and the failures are only due to lint.
c08471b
to
94e6aa4
Compare
3fa11c9
to
7873dbb
Compare
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
2508425
to
15ae04a
Compare
15ae04a
to
74332ff
Compare
74332ff
to
39631ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Much needed cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work. Much appreciated.
What changes were proposed in this pull request?
smart_unicode
method and change its usage withsmart_str
wherever required. This also triggered adding an encoding param in thesmart_str
method for compatibility withsmart_unicode
switch.How was this patch tested?