Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-core] adds showReactAppPage to allow UI routing to pure frontend … #3745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjornalm
Copy link
Collaborator

@bjornalm bjornalm commented May 23, 2024

…(react) pages

What changes were proposed in this pull request?

This PR modifies the frontend router to support the loading of pure frontend apps, i.e. apps not dependent on being rendered by the server's mako files.

How was this patch tested?

Use this function if you want to show a React based application page 
for a specific url without the need to use legacy mako templates.
1. Add a new appsItem in HueSidebar.vue that links to the new url
2. Import the new React component at the top of this file.
3. Add a new object to the pageMapping array below as examplified here:  

Please review Hue Contributing Guide before opening a pull request.

@bjornalm bjornalm marked this pull request as draft May 23, 2024 09:21
@bjornalm bjornalm force-pushed the bjorn--Allow-UI-routing-to-pure-frontend-apps branch from 44838c1 to 5c0506e Compare May 23, 2024 09:28
@bjornalm bjornalm marked this pull request as ready for review May 23, 2024 09:29
@bjornalm bjornalm force-pushed the bjorn--Allow-UI-routing-to-pure-frontend-apps branch from 5c0506e to 5c43b11 Compare May 23, 2024 20:08
Copy link

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

@bjornalm bjornalm force-pushed the bjorn--Allow-UI-routing-to-pure-frontend-apps branch from 5c43b11 to 6144ede Compare September 30, 2024 09:55
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants