Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hive] Support complex data type sampling #3766

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Jun 25, 2024

What changes were proposed in this pull request?

  • Sample api added for nested/complex datatype
  • SQL generation for sampling
  • Handling the output

How was this patch tested?

  • Manually
  • Unittest

@agl29
Copy link
Collaborator Author

agl29 commented Jun 25, 2024

Pylint fixes in this PR might make it hard to review. To make it easier, you can look at this commit instead. It doesn't include the pylint fixes, so you can focus on the main changes.

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agl29 agl29 enabled auto-merge (squash) June 27, 2024 03:54
@agl29 agl29 merged commit c702fd7 into master Jun 27, 2024
4 of 5 checks passed
@agl29 agl29 deleted the complex_type_sampling branch June 27, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants