-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api][tools] Add swagger URL and UI for public APIs #3776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, almost!
Also did you test it out E2E?
yes, i have tested this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more review comments. Also please fix the linting issues flagged by CI checks.
desktop/core/src/desktop/urls.py
Outdated
@@ -202,6 +203,9 @@ | |||
] | |||
|
|||
dynamic_patterns += [ | |||
re_path('api/schema', SpectacularAPIView.as_view(),name='schema'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this mapping as well, I checked and its just downloading the schema for all the APIs. Is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we require this for QE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabraiz12 Can we change the mapping here to '^api/schema/?$'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing all the review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change-Id: I2af75fd420ba84d6fa85a8af92013b59d60c054e
Change-Id: I080794b1d9937d8f4474d80757e0e5f299d3ea51
This reverts commit 78d90ca.
This reverts commit 8ea41bb.
This reverts commit 255e034.
Change-Id: I9be2abda3c2af2e04dd63248bb084fa45f80d4fa
Change-Id: I34e3aa43f1905ac9cf901c1ce448071c61c459d5
Change-Id: Ic1fce350d5a1e526e26e12c4b626dfd54ea352c9
Change-Id: If0d3f5744f06262a7d0723d7939670a8abdb5a41
Add Swagger UI and URL for public url for easier QE Automation
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.