[Python3.11] Improve the regex expression #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agl29
requested review from
wing2fly,
amitsrivastava,
JohanAhlen,
ranade1 and
athithyaaselvam
wing2fly
approved these changes
Jul 31, 2024
| assert not "dontseeme" in out | ||
| assert re.sub("^ (?m)", "", """ | ||
| assert "dontseeme" not in out | ||
| assert re.sub("(?m)^ ", "", """ |
There was a problem hiding this comment.
Is there an official guideline doc from python.org? Please share the source.
There was a problem hiding this comment.
athithyaaselvam
approved these changes
Jul 31, 2024
agl29
added a commit
that referenced
this pull request
Aug 1, 2024
agl29
added a commit
that referenced
this pull request
Aug 1, 2024
agl29
added a commit
that referenced
this pull request
Aug 21, 2024
(cherry picked from commit 493543c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?