Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python3.11] Adding custom commit in sasl lib to support python3.11 #3805

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[Python3.11] Adding custom commit in sasl lib to support python3.11 #3805

merged 2 commits into from
Aug 7, 2024

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Jul 29, 2024 •
edited
Loading

What changes were proposed in this pull request?

  • Current sasl version does not support the python3.11
  • Repo already has the commit to support the python3.11
  • Moving this lib from the base_req file to ext-py3 folder as we will push the additional commit on that to support python3.11

How was this patch tested?

  • Locally

@agl29 agl29 force-pushed the upgrade_sasl branch 2 times, most recently from 6130b84 to a96aca8 Compare July 29, 2024 12:56
@agl29 agl29 force-pushed the upgrade_sasl branch 4 times, most recently from 4fb36de to 931aa89 Compare August 1, 2024 05:32
@agl29 agl29 requested a review from wing2fly August 1, 2024 11:15
ranade1
ranade1 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@ranade1 ranade1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@agl29 agl29 enabled auto-merge (rebase) August 7, 2024 03:20
@agl29 agl29 merged commit f75608c into master Aug 7, 2024
4 of 5 checks passed
@agl29 agl29 deleted the upgrade_sasl branch August 7, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranade1 ranade1 ranade1 approved these changes

@wing2fly wing2fly wing2fly approved these changes

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agl29 @wing2fly @ranade1