Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hive][left assist] Enhanced get_tables_meta to correctly fetch and display tables #3824

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[Hive][left assist] Enhanced get_tables_meta to correctly fetch and display tables #3824

merged 2 commits into from
Aug 20, 2024

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Aug 20, 2024 •
edited
Loading

What changes were proposed in this pull request?

  • Modified get_tables_meta to handle cases where more than 10,000 tables exist by implementing a loop to fetch all tables across multiple FetchResult calls.

How was this patch tested?

  • Manully
  • Unittest (?)

quadoss
quadoss approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@quadoss quadoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quadoss quadoss enabled auto-merge (squash) August 20, 2024 17:06
@quadoss quadoss merged commit 395d807 into master Aug 20, 2024
5 of 6 checks passed
@quadoss quadoss deleted the left_assist_tables branch August 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harshg999 Harshg999 Harshg999 approved these changes

@quadoss quadoss quadoss approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

@ranade1 ranade1 Awaiting requested review from ranade1

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agl29 @quadoss @Harshg999