Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Refactor old filebrowser methods to new public APIs #3836

Merged
merged 28 commits into from
Oct 28, 2024
Merged

[api] Refactor old filebrowser methods to new public APIs #3836

merged 28 commits into from
Oct 28, 2024

Conversation

Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Sep 4, 2024 •
edited
Loading

What changes were proposed in this pull request?

  • Clean all filebrowser APIs with improved logic as separate methods serving public APIs
  • Currently /upload, /extract, /compress APIs are not refactored -- that will be done in future PR.
  • Will add unit tests in future PR.

How was this patch tested?

  • Manually

@Harshg999 Harshg999 changed the title [api] Refactor old filebrowser methods to new public APIs [WIP][api] Refactor old filebrowser methods to new public APIs Sep 25, 2024
@Harshg999 Harshg999 self-assigned this Oct 4, 2024
@Harshg999 Harshg999 force-pushed the new-apis branch 3 times, most recently from 118d4e1 to a9609f6 Compare October 15, 2024 10:04
@Harshg999 Harshg999 enabled auto-merge (squash) October 25, 2024 13:47
@Harshg999 Harshg999 changed the title [WIP][api] Refactor old filebrowser methods to new public APIs [api] Refactor old filebrowser methods to new public APIs Oct 25, 2024
nidhibhatg
nidhibhatg approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@nidhibhatg nidhibhatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harshg999 Harshg999 merged commit 552850e into master Oct 28, 2024
6 checks passed
@Harshg999 Harshg999 deleted the new-apis branch October 28, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhibhatg nidhibhatg nidhibhatg approved these changes

@tabraiz12 tabraiz12 tabraiz12 approved these changes

@bjornalm bjornalm Awaiting requested review from bjornalm

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

@ramprasadagarwal ramprasadagarwal Awaiting requested review from ramprasadagarwal

@ranade1 ranade1 Awaiting requested review from ranade1

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

@agl29 agl29 Awaiting requested review from agl29

Assignees

@Harshg999 Harshg999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harshg999 @tabraiz12 @nidhibhatg