[ui-configuration] Convert the Configuration page within Administrator Server in ReactJS #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananya-agarwal
force-pushed
the
Configuration
branch
from
27e1657
to
8c610a0
Compare
ananya-agarwal
force-pushed
the
Configuration
branch
4 times, most recently
from
2898b6c
to
68d5569
Compare
ananya-agarwal
force-pushed
the
Configuration
branch
2 times, most recently
from
1c48c1e
to
492ee86
Compare
ananya-agarwal
force-pushed
the
Configuration
branch
3 times, most recently
from
59c3ba6
to
9bd1725
Compare
ananya-agarwal
force-pushed
the
Configuration
branch
4 times, most recently
from
9ea914b
to
2a8e4be
Compare
ananya-agarwal
requested review from
tabraiz12,
JohanAhlen,
bjornalm,
ramprasadagarwal,
nidhibhatg and
Harshg999
ananya-agarwal
changed the title
ananya-agarwal
force-pushed
the
Configuration
branch
3 times, most recently
from
2e71ea0
to
a4a26cb
Compare
bjornalm
requested changes
Nov 6, 2024
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.tsx
Outdated
Show resolved
Hide resolved
ananya-agarwal
force-pushed
the
Configuration
branch
3 times, most recently
from
1d8dae6
to
26fea9f
Compare
Done till before bringing config in alignment styling changes fixing checks newly added WIP WIP WIP Renaming Linting fixed WIP WIP WIP WIP WIP WIP WIP WIP hey WIP WIP WIP WIP wIP WIP WIP
ananya-agarwal
force-pushed
the
Configuration
branch
from
26fea9f
to
236c80c
Compare
ananya-agarwal
force-pushed
the
Configuration
branch
from
bf8d745
to
0445e52
Compare
tabraiz12
reviewed
Nov 18, 2024
|
|
||
| .config__section-header { | ||
| color: $fluidx-gray-700; | ||
| } |
There was a problem hiding this comment.
indentation, do a style lint and fix indentation here.
| padding: 4px 0 8px 0; | ||
| } | ||
|
|
||
| padding: 16px 0 8px 16px; |
There was a problem hiding this comment.
if these styles(padding, bg-color,border) belongs to the config__main-item class add it on top itself instead of adding before closing of this class
| } | ||
|
|
||
| .config__main-item .config__child-item .config--last-heading { | ||
| font-size: $font-size-base; |
There was a problem hiding this comment.
add it on line 36, same class
tabraiz12
reviewed
Nov 18, 2024
| font-size: $font-size-base; | ||
| color: $fluidx-black; | ||
| font-weight: 400; | ||
| margin-left: 40px; |
There was a problem hiding this comment.
font-size and styles looks same for all child elements, we don't need to repeat them include these styles in parent class
| const filterConfig = ( | ||
| config: AdminConfigValue, | ||
| lowerCaseFilter: string | ||
| ): AdminConfigValue | undefined => { |
There was a problem hiding this comment.
is undefined required here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shifting the entire old code for the Configuration tab (page) which is present in Administrator server as a ReactJS component.
How was this patch tested?
Manual checking. Unit tests for all the components added.
Old Configuration page:
Updated Configuration page:
Please review Hue Contributing Guide before opening a pull request.