Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trino] Update drag and drop suggestions to use double quotes instead of backticks #3853

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[Trino] Update drag and drop suggestions to use double quotes instead of backticks #3853

merged 1 commit into from
Oct 1, 2024

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Sep 25, 2024 •
edited
Loading

What changes were proposed in this pull request?

  • Modified the code for Trino editor to use double quotes (") instead of backticks (`) when dragging and dropping a table from the left assist into the editor, as Trino does not support backticks for identifiers. This change ensures that table suggestions in the editor are correctly formatted and compatible with Trino syntax.

How was this patch tested?

Screenshot 2024-09-25 at 12 37 19 PM
  • Locally

bjornalm
bjornalm approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small change to the Regex if I'm not mistaken.

desktop/core/src/desktop/js/sql/sqlUtils.ts Show resolved Hide resolved
JohanAhlen
JohanAhlen approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agl29 agl29 merged commit ce781c6 into master Oct 1, 2024
6 checks passed
@agl29 agl29 deleted the trino_drag_drop_suggestions branch October 1, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornalm bjornalm bjornalm approved these changes

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

@Harshg999 Harshg999 Awaiting requested review from Harshg999

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agl29 @JohanAhlen @bjornalm