Skip to content

Conversation

ramprasadagarwal
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal commented Oct 15, 2025

What changes were proposed in this pull request?

  • Adding max width constraint along with media query to allow input fields in the settings tab to take a max 1024px.

How was this patch tested?

  • Added unit tests
Screen.Recording.2025-10-15.at.11.39.23.PM.mov

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this Oct 15, 2025
Copy link

github-actions bot commented Oct 15, 2025

✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅

Copy link

github-actions bot commented Oct 15, 2025

UI Code Coverage Report

Lines Statements Branches Functions
Coverage: 33%
39.91% (31323/78477) 31.59% (14623/46277) 25.94% (2361/9101)

Copy link

github-actions bot commented Oct 15, 2025

Coverage

Backend Code Coverage Report •
FileStmtsMissCoverMissing
TOTAL568892892649% 
report-only-changed-files is enabled. No files were changed during this commit :)

align-items: stretch;
position: relative;

.cuix.input {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct, that as a child of cuix we need another cuix class?

);
}
columns.push(column);
const columnsConfig: ColumnProps<FileChooserTableData>[] = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are these changes related to the max width in input fields?

align-items: stretch;
position: relative;

.cuix.input {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuix as a child of cuix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants