Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize encoding #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bencyoung-Fignum
Copy link

This change optimizes the binary mode formatter when UTF8 is chosen, and allows the memory stream implementation to be overridden (e.g. RecyclableMemoryStream)

@jskeet
Copy link
Contributor

jskeet commented Mar 20, 2024

Will try to look at this soon, but it may be next week.

@bencyoung-Fignum
Copy link
Author

It's no rush, we're just trying to optimize our eventing and this is something I wanted to check

@jskeet
Copy link
Contributor

jskeet commented Mar 21, 2024

There are a few things I'd probably want to change here - I wonder if the best thing is for me to create an PR from scratch rather than leave a bunch of nitpicks, then get you to review that new PR. Does that work for you?

@bencyoung-Fignum
Copy link
Author

Absolutely, it was just a PoC

@jskeet
Copy link
Contributor

jskeet commented Mar 21, 2024

Great. I'll try to come up with something next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants