Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PACKAGE.md for CloudNative.CloudEvents #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

captainsafia
Copy link
Contributor

Contributes to #290.

Starting off with just a PACKAGE.md for the central package. If this format looks good, I'll copy it to the other packages.

Signed-off-by: Safia Abdalla <safia@safia.rocks>
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General format looks great - thanks for this. Just a couple of suggestions for extra things to cover.

};
```

This package only provides the abstractions for constructing a CloudEvent. For complete deserialization and serialization behavior, you will need to use an accompanying formatter library. For more information on configuring and using CloudNative.CloudEvents, refer to the [official documentation](https://github.com/cloudevents/sdk-csharp/tree/main/docs).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly give an example one such formatter library? (I'd use the System.Text.Json formatter, personally.)

## Key Features

* Supports constructing a spec-compliant CloudEvent
* Provides abstractions for building custom CloudEvent formatters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add the HTTP binding support that's in this core package?

The main types provided by this library are:

* `CloudEvent`: Represents a spec-compliant CloudEvent.
* `CloudEventFormatter`: Provides an abstract class that can be extended to implement an event formatter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly mention extension methods (the names of the types are probably irrelevant) for HTTP conversion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants