Update README.md #1307
Open
Update README.md #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor fixes to readme
longz3r
reviewed
Aug 19, 2024
| @@ -1,10 +1,10 @@ | |||
| # Cloudflare Tunnel client | |||
|
|
|||
| Contains the command-line client for Cloudflare Tunnel, a tunneling daemon that proxies traffic from the Cloudflare network to your origins. | |||
| This daemon sits between Cloudflare network and your origin (e.g. a webserver). Cloudflare attracts client requests and sends them to you | |||
| via this daemon, without requiring you to poke holes on your firewall --- your origin can remain as closed as possible. | |||
| This daemon sits between Cloudflared network and your origin (e.g. a webserver). Cloudflare attracts client requests and sends them to you | |||
There was a problem hiding this comment.
"Cloudflare" should be more precise than Cloudflared
As Cloudflared is just a daemon connect to Cloudflare network. Cloudflared is not a network
There was a problem hiding this comment.
Hi @longz3r, by Cloudflare network, we mean cloudflared is between Cloudflare's edge network and your origin. We would prefer to keep the documentation this way. The rest of your changes looks good though. We are happy to accept this PR if you can revert this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fixes to readme