Fix off-by-one for histogram bucket seams #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
force-pushed
the
ivan/off-by-one-histogram
branch
2 times, most recently
from
4fde27c to
7157947
Compare
See cloudflare#488 for more details. With `exp2zero` histogram: * Go: ``` $ go run cmd/derp/main.go poc_metric_bucket{le="0"} 1 poc_metric_bucket{le="1"} 2 poc_metric_bucket{le="2"} 3 poc_metric_bucket{le="4"} 5 poc_metric_bucket{le="8"} 9 poc_metric_bucket{le="+Inf"} 9 poc_metric_sum 36 poc_metric_count 9 ``` * `ebpf_exporter`: ``` ebpf_exporter_poc_exp2zero_values_bucket{le="0"} 1 ebpf_exporter_poc_exp2zero_values_bucket{le="1"} 2 ebpf_exporter_poc_exp2zero_values_bucket{le="2"} 3 ebpf_exporter_poc_exp2zero_values_bucket{le="4"} 5 ebpf_exporter_poc_exp2zero_values_bucket{le="8"} 9 ebpf_exporter_poc_exp2zero_values_bucket{le="+Inf"} 9 ebpf_exporter_poc_exp2zero_values_sum 36 ebpf_exporter_poc_exp2zero_values_count 9 ``` With `exp2` histogram: * Go: ``` $ go run cmd/derp/main.go poc_metric_bucket{le="1"} 1 poc_metric_bucket{le="2"} 2 poc_metric_bucket{le="4"} 4 poc_metric_bucket{le="8"} 8 poc_metric_bucket{le="+Inf"} 8 poc_metric_sum 36 poc_metric_count 8 ``` * `ebpf_exporter` ``` ebpf_exporter_poc_exp2_values_bucket{le="1"} 1 ebpf_exporter_poc_exp2_values_bucket{le="2"} 2 ebpf_exporter_poc_exp2_values_bucket{le="4"} 4 ebpf_exporter_poc_exp2_values_bucket{le="8"} 8 ebpf_exporter_poc_exp2_values_bucket{le="+Inf"} 8 ebpf_exporter_poc_exp2_values_sum 36 ebpf_exporter_poc_exp2_values_count 8 ```
bobrik
force-pushed
the
ivan/off-by-one-histogram
branch
from
7157947 to
23cc1a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #488 for more details.
With
exp2zerohistogram:ebpf_exporter:With
exp2histogram:ebpf_exporter