Merged
Conversation
TheJokr
force-pushed
the
lblocher/fix-serde-parsing
branch
from
5abf864 to
7b46799
Compare
fisherdarling
approved these changes
Mar 6, 2026
darling, by default, throws an error when encountering an attribute that is not declared on a struct with `#[derive(FromMeta)]`. We silently swallowed that error and ignored the entire meta attribute, which caused a regression for the Default impls generated by `#[settings]`. To fix this, we now allow unknown fields on `SerdeArgs`. Additionally, we propagate errors from `SerdeArgs` parsing to make debugging such issues more straightforward in the future.
TheJokr
force-pushed
the
lblocher/fix-serde-parsing
branch
from
7b46799 to
2bb2656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
darling, by default, throws an error when encountering an attribute that
is not declared on a struct with
#[derive(FromMeta)]. We silentlyswallowed that error and ignored the entire meta attribute, which caused
a regression for the Default impls generated by
#[settings].To fix this, we now allow unknown fields on
SerdeArgs. Additionally,we propagate errors from
SerdeArgsparsing to make debugging suchissues more straightforward in the future.
Includes release commit for 5.5.1.